Extract functions #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version is more robust and easier to test, not yet implemented in main function. - added support for finding package.json files regardless of process.cwd() and supports nested directories - always yields an object to limit errors when using in unconventional setups - setup tap test suite to replace lab eventually
- uses .trim instead of a regex - add support for stderr
theworkflow
reviewed
Apr 20, 2017
| ], (err, results) => { | ||
| if (err) done(err) | ||
| else done(null, Object.assign({}, ...results)) | ||
| done(err, Object.assign({}, ...results)) |
There was a problem hiding this comment.
This is done to get all details regardless of errors right?
There was a problem hiding this comment.
Actually err never exists, all the tasks yield an {} when things go wrong. So, mostly this is just a simpler way to avoid adding // eslint-disable-line handle-callback-error and still get 100% coverage.
theworkflow
approved these changes
Apr 20, 2017
- removes lab and sinon devDependencies - rework test to focus on main flow - update scripts to use tap and require 100% coverage
jackboberg
force-pushed
the
extract-functions
branch
from
22bc183
to
6a647eb
Compare
|
Changes Unknown when pulling 6a647eb on extract-functions into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libfunctions more pure, and keep flow logic inindexsinonandlabwithtestdoubleandtap