set keepalive to appopiate value (since go 1.13 default is 15s) #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0nIg
changed the title
|
@paudley "paudley reacted with thumbs down emoji" why? |
Sorry, was a mistake! (undone) I'm doing some testing on the effects of shorter keepalives in our environments but I don't have results yet. |
|
That keep alive value goes all the way back to b46ee0a in 2014. At the time Go did not have TCP keepalive enabled by default. If a change is to be made here, I believe the correct change would be to remove the 5 minute value and actually use the Go default rather than hard code it to the current Go default. |
|
@jackc done |
jackc
reviewed
May 10, 2024
| @@ -800,7 +800,8 @@ func parsePort(s string) (uint16, error) { | |||
| } | |||
|
|
|||
| func makeDefaultDialer() *net.Dialer { | |||
| return &net.Dialer{KeepAlive: 5 * time.Minute} | |||
| // rely on GOLANG KeepAlive settings | |||
| return &net.Dialer | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set keepalive to appropiate value (since go 1.13 default is 15s).
5 minute for initial keepalive checks are way to high, we should orient us here according to go defaults
https://www.reddit.com/r/golang/comments/d7v7dn/psa_go_113_introduces_15_sec_server_tcp/