Fix interval encoding to allow 0s and avoid extra spaces #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bugs introduced by 01d649b, also add some tests
| @@ -132,29 +132,25 @@ func (encodePlanIntervalCodecText) Encode(value any, buf []byte) (newBuf []byte, | |||
|
|
|||
| if interval.Days != 0 { | |||
| buf = append(buf, strconv.FormatInt(int64(interval.Days), 10)...) | |||
| buf = append(buf, " day"...) | |||
| buf = append(buf, " day "...) | |||
There was a problem hiding this comment.
If months is 0, this will produce " day hh:mm:ss"
There was a problem hiding this comment.
nope, the number goes just before. There is a test with 0 months that looks good: https://github.com/jackc/pgx/pull/2035/files#diff-deeaa7f4bfb6897c6bb770fb12921f2350ce60ca3a2a5416c84a1ec23bb2b11eR151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bugs introduced by 01d649b, also add some tests
closes #2034