Merge options passed into all methods #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jackdempsey What do you think about this change? I agree with @kuraga that this makes more sense. Also, it would be great if a new version could be released so projects that depend on this feature can check that it is available. |
|
I think that looks fine, just gotta be careful about keys showing up that will conflict with calls unexpectedly. I don't use this code these days but [edit] I gave you access now and @kuraga also has access so I hope that helps. I can also add you to the rubygems account if desired. |
|
@shioyama I'll make a release soon. |
|
@kuraga Thanks! |
|
@jackdempsey push new version to RubyGems, please |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from #16, based on suggestion from @kuruga.