Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking issue in package.json #45

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Fix breaking issue in package.json #45

merged 1 commit into from
Oct 2, 2020

Conversation

alvaromontoro
Copy link
Contributor

Fix typo on package.json that breaks the whole build

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

There is a typo on package.json in the list of collaborators, and it's breaking the build. No code change involved.

Link(s)

Screenshot(s)

N/A

Checklist:

  • I have thoroughly read the CONTRIBUTING guidelines.
  • I understand my pull request will be thoroughly reviewed at high detail.
  • I understand the work in my pull request will only be available in the next version release of Checka11y.css and not in the current version release.
  • I confirm the work in this pull request is valid according to my findings and is not something for anything personal.
  • I have updated the README where and if applicable (still put an x if you have considered this but thought there was nothing to add or modify).
  • I have added myself to the contributors section in package.json (still put an x if you have considered this but decided not to add yourself).
  • I have checked I have not committed any accidental files.
  • I have tested all the main modern browsers (I.e. Chrome, Firefox, Edge, Safari - please leave this unchecked if there were any browsers listed you could not test and list them in the help section with details why you couldn't test that browser)
  • All new and existing a11y checks still work correctly (compare your local test/index.html to the test/index.html in the master branch).

Help

Fix typo on package.json that breaks the whole build
@alvaromontoro alvaromontoro changed the title Fix typo in package.json Fix breaking issue in package.json Oct 2, 2020
@jackdomleo7 jackdomleo7 added the bug Something isn't working quite right label Oct 2, 2020
@jackdomleo7 jackdomleo7 self-requested a review October 2, 2020 17:21
@jackdomleo7 jackdomleo7 merged commit c491643 into jackdomleo7:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quite right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants