Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use protobuf to send objects #8

Closed
skagawa2 opened this issue Oct 19, 2019 · 5 comments
Closed

Use protobuf to send objects #8

skagawa2 opened this issue Oct 19, 2019 · 5 comments
Assignees
@skagawa2
Labels
Priority: High Status: In Progress Team: Engine Type: Enhancement
Milestone
Server Communica...

Comments

@skagawa2
Copy link
Collaborator

  1. either create or get protobuf sending code from both visualizer and player
  2. make sure it works properly via unit testing
@skagawa2 skagawa2 self-assigned this Oct 19, 2019
@skagawa2 skagawa2 added this to the Server Communication milestone Oct 19, 2019
@skagawa2
Copy link
Collaborator Author

https://medium.com/@MelvinBlokhuijzen/spring-websocket-endpoints-integration-testing-180357b4f24c
Probably relevant link for reference later.

@skagawa2
Copy link
Collaborator Author

https://dzone.com/articles/understanding-the-basics-of-spring-vs-spring-boot
It looks like Spring Boot might be easier to use than Spring, will work on a new branch and try to refactor into Spring Boot

skagawa2 added a commit that referenced this issue Oct 19, 2019
@skagawa2
restarting using spring boot, using spring boot tutorial to start see #8
a82bd43
@skagawa2 skagawa2 changed the title Tests for Spring Use protobuf to send objects Nov 17, 2019
@skagawa2
Copy link
Collaborator Author

@sahilshahpatel could you put in a simple protobuf compiled class for PlayerTurn for now? In server -> communication -> player -> model -> PlayerDecision.java

@skagawa2 skagawa2 mentioned this issue Nov 17, 2019
Closed
@sahilshahpatel
Copy link
Collaborator

Done! For now the protobuf only has a String id as a placeholder.

@skagawa2 skagawa2 closed this as completed Dec 8, 2019
@skagawa2
Copy link
Collaborator Author

skagawa2 commented Dec 8, 2019

Issue should be discussed in mm26-protos

@sahilshahpatel sahilshahpatel mentioned this issue Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skagawa2 skagawa2

Labels
Priority: High Status: In Progress Team: Engine Type: Enhancement
Projects
None yet
Milestone
Server Communication
Development

No branches or pull requests
3 participants
@sahilshahpatel @jackducham @skagawa2