Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support yaml uploads #10

Merged
merged 2 commits into from
Oct 20, 2018
Merged

Support yaml uploads #10

merged 2 commits into from
Oct 20, 2018

Conversation

jackellenberger
Copy link
Owner

@jackellenberger jackellenberger commented Oct 20, 2018

Resolves #9

Sometimes emoji live in yaml files. that's cool. we can support those.

We're expecting yamls to look like:

--- 
any_ignored_key: whatever
emojis:
  - name: emoji1
     src: emoji-src.jpg
  - name: emoji2
     is_alias: 1
     alias_for: emoji1

Either src or url can be used for the source image.

This also fixes the bug that i made by uhhhhh breaking upload somewhere down the line when called directly via cli. i should probably integration test the cli too. ugh.

Lastly, there was a weird thing where uploads were disappearing because superagentTrhottle was just eating my requests whole. very unclear why that was happening, but i've disabled superagentThrottle on emoji src retrieval for now. let me know if you get rate limited...

@jackellenberger jackellenberger merged commit 8677494 into master Oct 20, 2018
@jackellenberger jackellenberger deleted the support-yaml-uploads branch October 20, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload with YAML file
1 participant