Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] [webui]: Add colour coding to indexer results paragraph #15080

Closed
1 task done
vonvenera opened this issue Feb 24, 2024 · 4 comments · Fixed by #15088
Closed
1 task done

[enhancement] [webui]: Add colour coding to indexer results paragraph #15080

vonvenera opened this issue Feb 24, 2024 · 4 comments · Fixed by #15088

Comments

@vonvenera
Copy link
Contributor

vonvenera commented Feb 24, 2024

Is there already a request for your feature?

  • I have checked older issues, open and closed

Is your feature request related to a problem? Please describe.

Not a problem, but it makes it easier to spot indexers that returned errors, no results or max results, especially if using10+ indexers.

Describe the solution you'd like

Add color coding to list of indexers used in search:

  • red for error
  • opacity0.5 for no results
  • yellow for indexers that returned max number of results, indicating that search query was not specific enough

Question: Is there a way to know for all (or most) indexers if they query generated more results than displayed (for example, multiple pages of results, but Jackett only parses the first one)?
If not, how hard would it be to add this? One solution is to add textbox into tracker configuration for users to enter max number of results configured for that tracker. If user does not add any number, they never see yellow style.

Example:
image

If approved, I can submit PR.

Describe alternatives you've considered

No response

@garfield69
Copy link
Contributor

Question: Is there a way to know for all (or most) indexers if they query generated more results than displayed (for example, multiple pages of results, but Jackett only parses the first one)? If not, how hard would it be to add this?

The current design of Jackett does not allow for that information to be made available. There are multiple enhancement tickets open for adding pagination processing, but most have stalled.
Currently, Jackett aims to retrieve up to 100 results, preferably from the first page of the sites torrent search page. But some site only offer as little as 10 results per page, some 25, others 40.
Jackett avoids performing multiple page fetches, if possible, to try to reach the 100 quota, even with embedded delays between requests.
These days, many sites are hyper sensitive to potential DDoS attacks, and Jackett tries to avoid stressing sites into blocking the users IP address or being labelled a spammer or worse.

The Jackett dashboard search is actually a small part of the Jackett function, its main goal is to provide Torznab responses for *arr apps, which only expect up to 100 results (some reject more), and do not need to fetch every possible result in one request as they provide a full query, so usually get back a smaller number of specific results.
Its only dashboard search users that are vague in their query keyword usage, and this minority are not worth the effort to rewrite Jackett significantly to support your yellow coded suggestion.

I would suggest red for error, green for success and leave it at that.

I'm always open to opinions from the other team members, so don't treat what I've said as the definitive answer set in concrete. ;-)

@garfield69 garfield69 changed the title [req] [webui]: Add colorcoding to indexer results paragraph [enhancement] [webui]: Add colour coding to indexer results paragraph Feb 24, 2024
@vonvenera
Copy link
Contributor Author

vonvenera commented Feb 24, 2024

Thanks for your feedback.

These days, many sites are hyper sensitive to potential DDoS attacks, and Jackett tries to avoid stressing sites into blocking the
users IP address or being labelled a spammer or worse.

Its only dashboard search users that are vague in their query keyword usage, and this minority are not worth the effort to rewrite Jackett significantly to support your yellow coded suggestion.

I would suggest red for error, green for success and leave it at that.

Yea, this makes sense. I wasn't thinking about performing extra requests per tracker for single dashboard search, more in the lines of... if parser, while parsing first page of results, also takes a look at the pagination on the tracker's 1st results page and returns total number of torrents along with actual torrents from first page. I could make use of that, but its not something to add just for a bit of styling on dashboard search page.

@ilike2burnthing
Copy link
Contributor

Red for error makes sense. I do like 0.5 opacity/grey for 0 results (a quick way to identify them, without being in your face), then just leave those with results as black, rather than making things too colourful.

Make a PR, we can comment more once we can play around with it, get a better idea of how it looks. Thanks.

@garfield69
Copy link
Contributor

v0.21.1855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants