Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax lenses are very single-purpose #84

Closed
jackfirth opened this issue Jul 8, 2015 · 3 comments
Closed

Syntax lenses are very single-purpose #84

jackfirth opened this issue Jul 8, 2015 · 3 comments
Assignees
Labels

Comments

@jackfirth
Copy link
Owner

I initially made these for use in very specific problems in other projects. They don't really belong in the general lens package, at least not with the same status as the other lenses. Possible fixes include:

  • Move to a lens/unstable collection or something that similarly signals they're not to be relied upon heavily. This would prevent them from getting locked into the API forever with 1.0
  • Move to an entirely separate package which provides a lens/syntax collection. There would probably have to be more syntax lenses to justify this, but it would give the most flexibility as that package could be versioned and managed separately.
  • Remove them from the package catalog entirely and just keep them as private to wherever I needed them originally.

They should probably be excluded from 1.0 and hidden until it's decided what to do with them.

@jackfirth
Copy link
Owner Author

#86 removed syntax lenses, making this no longer necessary for 1.0

@jackfirth jackfirth removed this from the 1.0 milestone Jul 8, 2015
@AlexKnauth
Copy link
Collaborator

A lens/syntax/... sub-collection makes sense to me.

@jackfirth
Copy link
Owner Author

That definitely makes sense as a final destination, but it should probably initially be provided in something which doesn't commit to backwards compatibility as I'm pretty unsure what else should go in such a collection or whether these lenses should be named differently or have different semantics. Perhaps an unstable/lens/syntax collection to start with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants