-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filterer-lens #147
add filterer-lens #147
Conversation
AlexKnauth
commented
Aug 17, 2015
P.S. I'm not sure: will this |
No it won't, because it messes with the order, |
What if only operated on sets? Then I think it would obey the laws. We'd need set lenses though. |
I'm already working on a version for sets. |
d004b05
to
07ea931
Compare
Given that on lists filter lenses breaks the lens laws, I think we should only make lens constructors for filter/filter-not/partition on sets. It seems counter-intuitive to do it with lists, as with sets lens let you change a subset matching a property but on lists that doesn't feel like it would be a sensible use case. |
Re: partition-lens. Not sure if that would be ugly to use, since lenses can't have multi-value views. |
Ok I'll remove the list ones then. |
The set version is now in #161 . |