This repository has been archived by the owner on Sep 4, 2023. It is now read-only.
Updated Setup.py to remove Pasteurize #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the following logic as Python 2 is being retired globally starting in 2020
from setuptools.command.build_py import build_py
:
:
class PasteurizeBuildCommand(build_py):
def run(self):
call(["pip", "install", "future"])
call(["pasteurize", "./pyramda"])
build_py.run(self)
:
:
cmdclass={
'build_py': PasteurizeBuildCommand
},
Removed the version -2.6 and -2.7 from .travis.yml as the Python 2.x support is dropped entirely. Made changes to the setup.py jcls as well to remove the Pasteurize.
jackfirth
reviewed
Oct 4, 2019
setup.py
Outdated
| @@ -30,8 +21,5 @@ def run(self): | |||
| ], | |||
| install_requires=['future'], | |||
There was a problem hiding this comment.
Is future still needed to install things?
There was a problem hiding this comment.
Hi Jack, its not required, i will remove it.
There was a problem hiding this comment.
Hi Jack,
I have made the following changes:
- In Travis.yml, removed and added the versions (in travis.yml) that are listed in the link that you provided,
- In Flatten.py, removed "from past.builtins import basestring" and added "from past.builtins import str" as basestring is not compatible with Python 3.
- In Setup.py, removed "from setuptools.command.build_py import build_py"
Thanks,
Vijay
jackfirth
reviewed
Oct 4, 2019
| @@ -1,15 +1,6 @@ | |||
| from setuptools import setup | |||
| from setuptools.command.build_py import build_py | |||
| from subprocess import call | |||
There was a problem hiding this comment.
I think this import can be removed now too
|
For the Travis CI issues, I think dropping 3.3 from the CI config is the right way to go. Could you also add the newer versions? I think we want every version on this list except for 2.7. |
|
Also, thank you so much for this pull request! It's something that's been bothering me for literal years. |
Removed install_requires=['future'], from the code as it is no longer required because we are removing all the python 2.* support entirely.
Removed version 3.3 and added the following versions: - "3.6" - "3.7" - "3.7-dev" - "3.8-dev" - "nightly"
Removed - from past.builtins import basestring
basestring is not compatible with Python 3 so replaced it with string_types
from builtins import basestring
|
CI is passing, so looks good to me 👍 Merging! |
This was referenced Oct 5, 2019
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the following logic as Python 2 is being retired globally starting in 2020
from setuptools.command.build_py import build_py
:
:
class PasteurizeBuildCommand(build_py):
def run(self):
call(["pip", "install", "future"])
call(["pasteurize", "./pyramda"])
build_py.run(self)
:
:
cmdclass={
'build_py': PasteurizeBuildCommand
},