Adds protocol support to make-domain-requester

[DarrenN]

When setting up a domain-requester you can pass the optional #:protocol keyword to enable HTTPS URLs. The default remains HTTP.

Example:

(make-domain-requester "httpbin.org" http-requester #:protocol "https")

[DarrenN]

Hmmm, the tests pass but there seems to be an issue with coveralls?

[jackfirth]

Rather than adding an option to make-domain-requester, how about adding a separate make-https-requester procedure that wraps a requester and transforms the urls it uses to https urls? That makes it easier to add https to requesters created via other means.

[jackfirth]

Not sure why Coveralls is failing, and the Travis racket versions need to be updated anyways. I'll look into that next time I get a chance.

[DarrenN]

@jackfirth that makes sense. Pushed up a new commit adding make-https-requester.

[jackfirth]

I think make-https-requester shouldn't work with a domain and should only change the URL of requests made with the underlying requester to HTTPS. Something like (wrap-requester-location http-url->https-url requester).

[DarrenN]

Okay I think this follows along with what you suggested:

(make-domain-requester domain (make-https-requester http-requester))

Also updated the tests and added the integration-test submodule. I think I correctly modified the .travis.yml file as well.

[jackfirth]

You'll need two test commands, the original one that runs unit tests and this one to run integration tests. Otherwise any (module+ test body ...) forms elsewhere in the package won't run. I haven't actually written any tests though, so technically not a big deal.

[jackfirth]

This looks great 👍 Thanks for sticking with it through review, and thanks for implementing this! Would you be willing to write some docs for it? I'll try and fix the travis/coveralls issues tonight.

[DarrenN]

This has been great, a nice lesson in composition for sure. Will write up some docs tonight. I've also been working on a json-requester branch, will review that some more in light of this discussion before I PR it.

Thank again!

[jackfirth]

If you'd like I can assign #12 to you then, json requesters has been on my list for some time.

[DarrenN]

Pushed up docs for make-https-requester. Sure I'll take a swing at #12

[jackfirth]

Merged #23, fixed cover and now it builds on more versions. You'll have to rebase.

[coveralls]

Coverage decreased (-0.09%) to 84.681% when pulling 8c3b163 on DarrenN:add-protocol into 537438f on jackfirth:master.

[DarrenN]

Nice to see the tests run against so many different Rackets.