-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON Requester #24
base: master
Are you sure you want to change the base?
JSON Requester #24
Conversation
Looks like some deps didn't install correctly on older versions of Racket. Usually I would restart the travis build but that doesn't seem to be an option on the free version. Hoping it will shake out on future commits pushed up to this PR. |
I have some general comments before addressing specifics:
|
I think I addressed most of your comments in the recent push:
Ideally I would have liked to keep the |
Went ahead an rolled a new exception ( |
Fixes #12
json-requester
json-requester
returnsjson-response
structjson-requester
the following headers are automatically injected:Accept: application/json
andContent-Type: application/json
. These can be overridden as normal.json-requester
thebody
needs to be a validjsexpr?
and will be automatically converted to a bytes representation of a JSON string (ex:(hasheq 'grand "larceny")
->"{\"grand\": \"larceny\"}"
)json-response
expects the response body to be a validjsexpr?