-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
My recs #1
Open
ryanhaining
wants to merge
10
commits into
jackfischer:master
Choose a base branch
from
ryanhaining:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
My recs #1
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
00be091
Replaces malloc()'d buffer (leak) with std::vector
ryanhaining def9db1
Uses makefile macros to avoid repetiton.
ryanhaining 592b360
Adds makefile flags for clang on Linux
ryanhaining cfd2017
Uses implicit make rules
ryanhaining ed84365
logs errors with cerr instead of cout
ryanhaining 6a2408b
moves header guard to top
ryanhaining 8b0655d
Moves "css" type alias into class definition
ryanhaining cc805ed
Uses std::array for colors.
ryanhaining 43f35c9
Adds FIXMEs about once-run loops
ryanhaining 8248ff1
Box ctor changed to take std::array&
ryanhaining File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,12 +8,10 @@ extern "C" { | |
} | ||
#include <iostream> | ||
#include <string> | ||
#include <vector> | ||
#include <strings.h> | ||
#include <string.h> | ||
#include <unistd.h> | ||
|
||
#define BUFFER_SIZE 10000 | ||
|
||
void Http::connect(std::string url) { | ||
extern int h_errno; | ||
const char *nameC = url.c_str(); | ||
|
@@ -35,15 +33,12 @@ void Http::connect(std::string url) { | |
} | ||
|
||
std::string Http::makeRequest(const char *req) { | ||
constexpr auto BUFFER_SIZE = 10000; | ||
send(Http::sck, req, std::string(req).length(), 0); | ||
char* buffer = (char *)malloc(BUFFER_SIZE); | ||
memset(buffer, 0, BUFFER_SIZE); | ||
std::string response; | ||
sleep(1); | ||
read(Http::sck, buffer, BUFFER_SIZE-1); | ||
response = std::string(buffer); | ||
//std::cout<<response; | ||
return response; | ||
std::vector<char> buffer(BUFFER_SIZE); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you really were to malloc, the most C++-ish thing here would've been |
||
read(Http::sck, buffer.data(), buffer.size()); | ||
return {buffer.data()}; | ||
} | ||
|
||
std::string Http::dropHeaders(std::string doc) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::string(req).length()
should bestd::strlen(req)
mah b.