Skip to content

Commit

Permalink
v2.0.1: updating deps and minor js tweaks
Browse files Browse the repository at this point in the history
  • Loading branch information
jameelmoses committed Aug 8, 2019
1 parent a5adced commit c76ffab
Show file tree
Hide file tree
Showing 6 changed files with 189 additions and 751 deletions.
3 changes: 1 addition & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Firstly, contributions are hugely welcomed and much appreciated!

__If you've never contributed to an open source project before, please don't let that put you off!__ I am more than happy to help with PRs, etc, please ping me on GitHub or email jack at jackfranklin dot net.
__If you've never contributed to an open source project before, please don't let that put you off!__ I am more than happy to help with PRs, etc, please ping [me](https://github.com/jackfranklin) or [Jameel](https://github.com/jameelmoses) on GitHub.

### Working on an issue

Expand All @@ -18,4 +18,3 @@ Before you start working on an idea, make sure:
- Be sure to add yourself as a contributor to the [package.json](https://github.com/jackfranklin/gulp-load-plugins/blob/master/package.json) file.
- If possible, write a test that covers the bug fix / feature addition that you're making. If you're unsure how to write the test, open your PR first and someone will help you.
- If you have any questions at all, please don't hesitate to get in touch. We're here to help :)

11 changes: 11 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,18 @@ Due to the native support of ES2015 syntax in newer versions of Node, this plugi

## Install

NPM:

```sh
$ npm install --save-dev gulp-load-plugins
```

Yarn:

```sh
$ yarn add -D gulp-load-plugins
```


## Usage

Expand Down Expand Up @@ -194,6 +202,9 @@ Credit largely goes to @sindresorhus for his [load-grunt-plugins](https://github

## Changelog

##### 2.0.1
- Update dependencies and minor JS improvements

##### 2.0.0
- Drop support for old Node. Minimum version now Noda >= 8. Update all dependencies. Refactor some code with ES6. - thanks @TheDancingCode - [PR](https://github.com/jackfranklin/gulp-load-plugins/pull/134)

Expand Down
5 changes: 2 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ function getPattern(options) {

module.exports = function(options) {
const finalObject = {};
let configObject;
let requireFn;
options = options || {};

Expand Down Expand Up @@ -76,7 +75,7 @@ module.exports = function(options) {
requireFn = require;
}

configObject = (typeof config === 'string') ? require(config) : config;
const configObject = (typeof config === 'string') ? require(config) : config;

if (!configObject) {
throw new Error('Could not find dependencies. Do you have a package.json file in your project?');
Expand Down Expand Up @@ -153,7 +152,7 @@ module.exports = function(options) {
if (scopeTest.test(name)) {
decomposition = scopeDecomposition.exec(name);
if (maintainScope) {
if (!fObject.hasOwnProperty(decomposition[1])) {
if (!Object.prototype.hasOwnProperty.call(fObject, decomposition[1])) {
finalObject[decomposition[1]] = {};
}
fObject = finalObject[decomposition[1]];
Expand Down
18 changes: 9 additions & 9 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gulp-load-plugins",
"version": "2.0.0",
"version": "2.0.1",
"description": "Automatically load any gulp plugins in your package.json",
"scripts": {
"test": "npm run lint && NODE_PATH=test/global_modules mocha",
Expand Down Expand Up @@ -44,22 +44,22 @@
"dependencies": {
"array-unique": "^0.3.2",
"fancy-log": "^1.2.0",
"findup-sync": "^3.0.0",
"findup-sync": "^4.0.0",
"gulplog": "^1.0.0",
"has-gulplog": "^0.1.0",
"micromatch": "^4.0.2",
"resolve": "^1.1.7"
"resolve": "^1.12.0"
},
"devDependencies": {
"capture-stream": "^0.1.2",
"eslint": "^6.0.1",
"eslint-config-standard": "^12.0.0",
"eslint-plugin-import": "^2.18.0",
"eslint": "^6.1.0",
"eslint-config-standard": "^13.0.1",
"eslint-plugin-import": "^2.18.2",
"eslint-plugin-node": "^9.1.0",
"eslint-plugin-promise": "^4.2.1",
"eslint-plugin-standard": "^4.0.0",
"mocha": "^6.1.4",
"proxyquire": "^2.1.0",
"sinon": "^7.3.2"
"mocha": "^6.2.0",
"proxyquire": "^2.1.1",
"sinon": "^7.4.1"
}
}
2 changes: 2 additions & 0 deletions test/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-disable quote-props */

'use strict';
const assert = require('assert');
const sinon = require('sinon');
Expand Down

0 comments on commit c76ffab

Please sign in to comment.