Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove factory name #607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Glinkis
Copy link
Contributor

@Glinkis Glinkis commented Jan 22, 2022

Removes the unused factory name argument. This simplifies the build function arguments a bit.

@jackfranklin
Copy link
Owner

Nice! I'm not sure why the tests aren't running on your PRs, but I think they will need updating as they all pass a factory name in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants