Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Merge upstream master #31

Merged
merged 17 commits into from May 4, 2021
Merged

chore: Merge upstream master #31

merged 17 commits into from May 4, 2021

Conversation

jackgerrits
Copy link
Owner

No description provided.

lalo and others added 16 commits April 26, 2021 12:03
@lalo
feat: Add cb_to_cb_adf reduction (VowpalWabbit#2680)
fbed882 
This will 'translate' cb (non adf) input commands into their cb_adf counterparts
    Except when:
        - the model file loaded is from a version older than and not including 8.11.0
        - user bypasses this translation step using '--cb_force_legacy'

Breaks: predict format, output format of progressive validation. This is due to the input format of cb.
--cb input format does not include 0 as a valid action, cb_adf uses 0 to represent the action 1. This will merge the behavior between the cb and cb_adf branch.

    Related files: cb_algs.cc, cb_explore.cc, cbify.cc, cb_to_cb_adf.cc
@lalo
feat: [cb cb_adf] prog val print known label (VowpalWabbit#2957)
e7936c4
@jackgerrits
refactor: migrate active_cover learner init (VowpalWabbit#2960)
dd4f7c2
@jackgerrits
feat: consolidate math functions and add combinatorial related funcs (V…
edf00a9 
…owpalWabbit#2965)

* feat: consolidate math functions and add combinatorial related funcs

* formatting
@lalo
feat: [cb_adf_explore] prog val print known label (VowpalWabbit#2961)
4a2b585
@jackgerrits
ci: Make LGTM ignore ext_libs directory (VowpalWabbit#2967)
dfca978
@jackgerrits
test: Add tests for vw_math and fix one function (VowpalWabbit#2966)
83a7917 
* test: Add tests for vw_math and fix one function

* formatting
@lalo
feat: add optional extra metrics (VowpalWabbit#2959)
183bc33 
  --extra_metrics filename 
Specify filename to write additional debug metrics to. Note: There is no fixed schema. Depends on specific reductions.

related: VowpalWabbit#2805
@jackgerrits
refactor: Remove unused foreach_feature func (VowpalWabbit#2973)
b1f8539
@jackgerrits
fix: fixes for headers not including things they need (VowpalWabbit#2974
89a7fe1 
)

* Fix includes

* fix more headers

* Fix more headers

* formatting

* undo changes

* dont include on windows

* formatting

* Update mwt.h

* mutex header
@cirvine-MSFT @olgavrou
Fixing json parse issue when pdrop is 0 (VowpalWabbit#2977)
e3769cf 
Co-authored-by: olgavrou <olvrousg@microsoft.com>
@jackgerrits
fix: Avoid float to double promotion by using C++ version of math fun…
4eeecd3 
…ctions (VowpalWabbit#2979)
@jackgerrits
fix: use nullptr instead of NULL (VowpalWabbit#2980)
4f0fe62
@jackgerrits
Merge branch 'master' into overhaul
a4ec891
@jackgerrits
merge tests
7e0e911
@jackgerrits
Fix merge
cb5cad4
@jackgerrits jackgerrits changed the title Merge upstream master chore: Merge upstream master May 4, 2021
@jackgerrits jackgerrits merged commit 534089c into overhaul May 4, 2021
@jackgerrits jackgerrits deleted the merge_master branch May 4, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackgerrits @lalo @cirvine-MSFT