chore: merge with upstream #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will 'translate' cb (non adf) input commands into their cb_adf counterparts
Except when:
- the model file loaded is from a version older than and not including 8.11.0
- user bypasses this translation step using '--cb_force_legacy'
Breaks: predict format, output format of progressive validation. This is due to the input format of cb.
--cb input format does not include 0 as a valid action, cb_adf uses 0 to represent the action 1. This will merge the behavior between the cb and cb_adf branch.
Related files: cb_algs.cc, cb_explore.cc, cbify.cc, cb_to_cb_adf.cc
…owpalWabbit#2965) * feat: consolidate math functions and add combinatorial related funcs * formatting
* test: Add tests for vw_math and fix one function * formatting
--extra_metrics filename Specify filename to write additional debug metrics to. Note: There is no fixed schema. Depends on specific reductions. related: VowpalWabbit#2805
Co-authored-by: olgavrou <olvrousg@microsoft.com>
* fix: Unify dulicated error code headers * formatting
* refactor: do not use c style casts * formatting * Add back cast * formatting
* Refactor feature iterators * Fix unique sort * fixup * Fix increments * Use ptr for audit() since it is optional * formatting * to_flatbuffer
) This will be used in RLClientLib to enable the dotnet bindings to pass size information and fix a crash; the alternate fix would be to force a \0 terminator on the .NET side * Also deprecates un-sized call, as it safer to expect the caller to have run strlen, rather than assume it is safe to run. Co-authored-by: @jackgerrits
* style: give template parameters more descriptive names * Formatting * Fix typos * update names * Fix formatting issues
…lWabbit#2929) * Set up .NET/CLI-compatible build environment on WIN32 * Flatten output structure (enable native dependencies to be copied SxS with managed) * Set up correct TargetFrameworkVersion * Enforce CMake version minimum when building .NET bindings * Unify WIN32-specific configuration in one CMake include * Get VW.Net Common library building under CMake * Get VW.Net managed C++ building under CMake * Get VW.Net managed wrapper building under CMake * Pull out NuGet package integration to CMake module * Get VW.Net JSON bindings building under CMake * Get VW.Net Parallel bindings building under CMake * Enable StrongName signing * Get VW.Net Console building under CMake * Get .NET UnitTests building under CMake * Integrate C# UnitTests into test_with_output * Fix issue with vw-unit-test CTest when output is redirected * Get VW.Net non-"friend" UnitTests building under CMake * Integrate C# non-"friend" UnitTests into test_with_output * Get .NET Simulator building under CMake * Update T4Template utility to run T4 tool on configure * This takes the generated sources of out the sourcetree * Update for PR comments * Normalize .cmake file casing * Clarify option naming (NETFX => NET_FRAMEWORK) * Spelling and whitespace fixes * Update target names to match pre-CMake targets * Fix warnings in search_generate.cc * Change Windows CMake pipeline to use VS generator * Fix formatting issues Co-authored-by: Jack Gerrits <jackgerrits@users.noreply.github.com> Co-authored-by: Jack Gerrits <jack@jackgerrits.com>
* perf: Use float instead of float ref * Fix formatting issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.