Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculated height when box-sizing: border-box on firefox 28- #242

Closed
djeremh opened this issue Jul 1, 2015 · 1 comment
Closed

Comments

@djeremh
Copy link

djeremh commented Jul 1, 2015

I ran over an issue specific to firefox 28 and older versions.

It seems there is a wrong implementation on padding in textarea in these browsers.
https://bugzilla.mozilla.org/show_bug.cgi?id=157846
It means that scrollHeight is incorrectly calculated (not taking paddings in the calculation).

As you fix the issue if box sizing is padding box, it is not the case when box-sizing: border-box;

Moreover, if i add a min-height to the text area, I had a browser freeze due to the potential endless loop of update() calling changeOverflow() calling update() and so on.

You can test this on https://jsfiddle.net/dyvt9euf/6/ using a firefox 28 or older

I am working on a fix, right now.

@djeremh
Copy link
Author

djeremh commented Jul 2, 2015

Here is the pull request : #243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants