Radio bugfix & returned value attribute value for checkable inputs. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`selected` isn't an attribute of radio elements, they use `checked` just like checkboxes. Checkboxes and radios have a value attribute, so that attribute value should be returned instead of the checked state. See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input > A radio button. You must use the value attribute to define the value submitted by this item. Use the checked attribute to indicate whether this item is selected by default.
I believe the only elements that the browser will recognize the disabled attribute for are input, textarea, select, and keygen. Since you can't nest these elements inside of each other, there should be no need to check ancestor elements for disabled.
no dependencies needed.
|
oops. added on npm and added as collab. also, the closest stuff is for |
Good point, thanks. |
|
Refactored in a different commit. |
|
Thanks for adding as collaborator, let me know if you have any objections to the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectedisn't an attribute of radio elements, they usecheckedjust like checkboxes. Checkboxes and radios have a value attribute, so that attribute value should be returned instead of the checked state.See https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input