Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model config #121

Merged
merged 12 commits into from
Apr 11, 2024
Merged

Model config #121

merged 12 commits into from
Apr 11, 2024

Conversation

cheeseonamonkey
Copy link
Contributor

@cheeseonamonkey cheeseonamonkey commented Mar 30, 2024

Mostly refactoring the new model config stuff, without changing anything:

  • extracted a component for each model's config UI:
    f6fae3c

  • refactored api.ts:
    0cc444e

  • add titles to each input fields (those HTML hover-popup labels)

  • added a fetch to the openai API to get all available models (not yet implemented):
    b290a87

@jackschedel
Copy link
Owner

Hi, thanks for the PR.
Can you run the prettier autoformat yarn format and commit it so I can get a better diff view?
I think many of your api.ts spacing refactors with the onChange inlines will be auto-formatted out.

@jackschedel
Copy link
Owner

Also, please remove the unused variables that ESLint is warning about.

@cheeseonamonkey
Copy link
Contributor Author

Oh yes, I see what you mean. I can clean it up a bit.

The original intent was to load the models dynamically from the OpenAI API, but some refactoring instincts kicked in first 😅

@jackschedel jackschedel merged commit b9bbce1 into jackschedel:main Apr 11, 2024
5 of 6 checks passed
@jackschedel
Copy link
Owner

@cheeseonamonkey Hi, while I initially did some brief testing and it seemed to work, after using it myself I've encountered issues where new model definitions do not save. I have reverted the PR. If you wish for these changes, fix the issues and make a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants