Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "greyworld" AWB option for input_raspicam #235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markus-k
Copy link

This pull-request updates the mmal library for the raspicam and adds the "greyworld" AWB option for use with the NoIR camera.

@kbowman-newedenconsultinggroup

Installed and working perfectly. Thanks for doing this pull!

@jantman
Copy link

jantman commented Oct 2, 2020

Any hope of getting this merged?

Confirmed that this fixes it for me as well. Before and after photos with my NoIR camera can be seen at https://github.com/jantman/OctoPi/releases/tag/greyworld-v1

@jacksonliam
Copy link
Owner

Thanks for this and sorry for the delay, I usually comment on PRs as I see them come in but have missed a few.

This obviously makes a big change to the mmal libraries copied into this repo, the problem I have with updating them is making sure things still work for people running e.g. old versions of raspbian (or at least fail with suitable messages).

I have some old Pis on old images for this testing purpose but when I test on them and things don't work it can be a long process to try and figure out why. For that reason I haven't merged anything which changes the mmal stuff for a while. The old Pis have also been packed away in boxes since March because I needed the office space to make a suitable day-job office. Once

I have the office sorted I will try to get the mmal stuff sorted and up to date ASAP, and look to make sure we can pass-through as many options as possible.

@GhostlyCrowd
Copy link

Sure would be nice to have this merged.......

@jantman
Copy link

jantman commented Mar 13, 2022

Just checking back on this again. I've been running off of a fork for a year and a half just because of this one feature :(

jantman added a commit to jantman/OctoPi that referenced this pull request Mar 13, 2022
@Nexpyro
Copy link

Nexpyro commented Apr 15, 2022

up
running jantman fork too only for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants