Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add SelectParams to Select for federation
When prom2 came out the storage querier interface consolidated to a single Select() method. While doing this it makes it impossible as the implementer of the querier to know if you are being called for metadata or actual data. The workaround has been to check if the SelectParams are nil, which the federation call is always nil. This has 2 negative consequences (1) remote implementations interpret this as a metadata call, which makes the federation endpoint return nothing. (2) this means that the storage implementations don't get the same information passed down to them as far as SelectParams goes. This diff simply adds SelectParams to the Select() call in the federation handler Mitigation for prometheus#4057 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>
- Loading branch information