Create mTLS functionality for promxy #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kira Boyle <kboyle@pivotal.io>
Signed-off-by: Devon Warshaw <warshawd@vmware.com>
Signed-off-by: Kira Boyle <kboyle@pivotal.io>
Signed-off-by: Devon Warshaw <warshawd@vmware.com>
…aceholder command Signed-off-by: Devon Warshaw <warshawd@vmware.com> Signed-off-by: Kira Boyle <kboyle@pivotal.io>
Signed-off-by: Robert Sullivan <rsullivan@pivotal.io>
|
The PR seems okay -- there looks to be some minor failures in ci (likely just a |
|
Thanks for the tip on the requirements! Went ahead and applied the requirements to hopefully fix the minor failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promxy was not leveraging mTLS. We tried to mimic the Prometheus approach using a
web.config.filecommand line argument.This resolves issue #432
Let us know if there's anything we need to fix, or if we can help speed up the acceptance process in any way.