Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric relabel support to promxy #554

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Add metric relabel support to promxy #554

merged 1 commit into from
Mar 14, 2023

Conversation

jacksontj
Copy link
Owner

@jacksontj jacksontj commented Mar 13, 2023

This is a fairly large feature, but the intent is to allow some subset of relabel capability to the metrics that flow through promxy. This is pretty heavily restricted because the rewrites need to be bi-directional (as we need to be able to modify the query we are sending downstream).

This enables a few major use-cases:

  • dropping labels (e.g. thanos replica labels)
  • renaming labels (e.g. migrating to a new label name)

Fixes #258

TODO:

  • LabelNames
  • LabelValues
  • Query
  • QueryRange
  • Series
  • GetValue

@jacksontj jacksontj marked this pull request as ready for review March 14, 2023 23:05
This is a fairly large feature, but the intent is to allow some subset
of relabel capability to the metrics that flow through promxy. This is
pretty heavily restricted because the rewrites need to be bi-directional
(as we need to be able to modify the query we are sending downstream).

This enables a few major use-cases:
  - dropping labels (e.g. thanos replica labels)
  - renaming labels (e.g. migrating to a new label name)

Fixes #258
@jacksontj jacksontj merged commit c09f92a into master Mar 14, 2023
@jacksontj jacksontj deleted the issue_258 branch March 14, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to merge results on replica label as Thanos Query does
1 participant