Frontend codacy errors #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelfu1029
force-pushed
the
frontend-codacy
branch
from
293b62d
to
1445ff6
Compare
wchang22
requested changes
Nov 2, 2019
| } else { | ||
| try { | ||
| await firebase.messaging().requestPermission(); | ||
| console.log('FCM permission granted'); | ||
| logger.log('FCM permission granted'); |
There was a problem hiding this comment.
It seems to me that react-native-logger is perhaps not the best logger to use if you cannot even distinguish between different log levels (i.e. debug, info, warn, error, etc). May want to try out js-logger, like used in the backend.
I've set stuff up so that it also prints out which module the log comes from, which is very useful.
wchang22
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed/refactored code to comply with codacy and eslint