Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic ocaml support + lexical scoping #149

Merged
merged 3 commits into from Jul 21, 2017

Conversation

rgrinberg
Copy link
Contributor

Will hopefully keep improving this as I use this

@coveralls
Copy link

coveralls commented Jul 21, 2017

Coverage Status

Coverage remained the same at 97.297% when pulling ab13959 on rgrinberg:ocaml-support into 265c265 on jacktasia:master.

@jacktasia
Copy link
Owner

Thanks for the PR! The only reason I can think for why it's only failing on emacs 24.3 in Travis is because of the lexical-bindings change. Thoughts?

@rgrinberg
Copy link
Contributor Author

I think that lexical bindings are a very good thing to use, but emacs 24.3 isn't that old and I'm not really understanding that error. So I'll get rid of it until you decide to drop support for 24.3

@coveralls
Copy link

coveralls commented Jul 21, 2017

Coverage Status

Coverage remained the same at 97.297% when pulling c2dfdf6 on rgrinberg:ocaml-support into 265c265 on jacktasia:master.

@jacktasia
Copy link
Owner

I think that lexical bindings are a very good thing to use, but emacs 24.3 isn't that old and I'm not really understanding that error. So I'll get rid of it until you decide to drop support for 24.3

Thanks! I totally agree.

@jacktasia jacktasia merged commit b8080d6 into jacktasia:master Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants