Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl support #162

Merged
merged 3 commits into from Sep 10, 2017
Merged

Jl support #162

merged 3 commits into from Sep 10, 2017

Conversation

AShedko
Copy link
Contributor

@AShedko AShedko commented Sep 10, 2017

Some changes

  • made types searchable
  • added some function decorators

response for this
#159

SIde note:
Does spacemacs lag behind melpa, as the changes are not awailable there?

@coveralls
Copy link

coveralls commented Sep 10, 2017

Coverage Status

Coverage remained the same at 96.835% when pulling 91fb6ad on AShedko:JlSupport into 6cc7a67 on jacktasia:master.

@jacktasia
Copy link
Owner

Awesome, thanks!

Does spacemacs lag behind melpa, as the changes are not available there?

I honestly don't use spacemacs, so I am not sure, but it could be:

  1. There is a spacemacs julia layer and it doesn't load dumb-jump for its keybindings?
  2. They use a mirror of MELPA that runs behind?

or maybe something else. if you can confirm the correct version of dumb-jump is installed after you upgrade (the only way I know to check is: M-x package-list-packages-no-fetch) then it's potentially number 1 and we may want to consider creating an issue with spacemacs.

@jacktasia jacktasia merged commit f6759d6 into jacktasia:master Sep 10, 2017
@AShedko
Copy link
Contributor Author

AShedko commented Sep 10, 2017

Apparently they use version 2017.08.21.13 .

@AShedko AShedko deleted the JlSupport branch September 10, 2017 21:07
@jacktasia
Copy link
Owner

jacktasia commented Sep 10, 2017

Apparently they use version 2017.08.21.13 .

It doesn't look like they pin versions yet. Have you tried upgrading dumb-jump manually? Try M-x package-refresh-contents then package-list-packages then on that buffer U (shift+u) then x

@AShedko
Copy link
Contributor Author

AShedko commented Sep 11, 2017

I got the latest version. Thank you. unfortunately i had no luck actually using the module as i keep getting
julia declaration not found errors.

@jacktasia
Copy link
Owner

unfortunately i had no luck actually using the module as i keep getting julia declaration not found errors.

Sorry, it didn't work. Could you please provide more information about your setup?

  • OS
  • shell
  • searcher (ag, grep, etc),
  • debug output (setting (setq dumb-jump-debug t) and then trying a jump and checking *Messages*)
  • example of code you're jumping from/to
  • check if another searcher works ((setq dumb-jump-force-searcher 'ag) See README)

This will help me track down where it's failing for you.

@AShedko
Copy link
Contributor Author

AShedko commented Sep 11, 2017

OS: GNU/Linux (Fedora 25) [Linux localhost.localdomain 4.12.8-200.fc25.x86_64 #1 SMP Thu Aug 17 15:39:27 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux]
shell: zsh
searcher: ag
debug output:

cmd: 
	ag --nocolor --nogroup --julia --jl \(\@noinline\|\@inline\)\?\\s\*function\\s\*subplot_data\\s\*\\\(\|const\\s\+subplot_data\\b\|\(mutable\)\?\\s\*struct\\s\*subplot_data\|\(type\|immutable\|abstract\)\\s\*subplot_data /home/ashedko/.julia/v0.6/Gadfly
raw results: 
	ag: unrecognized option '--jl'
Usage: ag [FILE-TYPE] [OPTIONS] PATTERN [PATH]
-----
DUMB JUMP DEBUG ‘dumb-jump-run-command‘ END
-----

setting grep as the searcher works.

I`m using Gadfly as a test

@jacktasia
Copy link
Owner

jacktasia commented Sep 11, 2017

The ag: unrecognized option '--jl' is telling us the problem.

My bad for not catching this in the PR, but you overrode the existing jl extension defs with bad rg and ag types.

Fixed in 5aa56fe

Thanks for getting me the debug details so fast.

@AShedko
Copy link
Contributor Author

AShedko commented Sep 11, 2017

Glad to help, I think I`ll add some more regexes for function declaration syntax.

netromdk pushed a commit to netromdk/dumb-jump that referenced this pull request Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants