Add SCSS support #169
Merged
Add SCSS support #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might not cover the entire spec, but it covers my use cases!
|
Thanks for the PR! Looks like the tests are not passing though. Looks like you're setting the I was able to fix them pretty easily: https://github.com/jacktasia/dumb-jump/compare/scss-tests -> https://travis-ci.org/jacktasia/dumb-jump/jobs/296997840 if you want to update your branch so you get credit for your work...or if you don't care I can just merge my branch. Up to you. Thanks again! |
|
Looks like I could push to your branch. Thanks! |
netromdk
pushed a commit
to netromdk/dumb-jump
that referenced
this pull request
Dec 2, 2017
* Add SCSS support This might not cover the entire spec, but it covers my use cases! * fix scss tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might not cover the entire spec, but it covers my use cases!
Also, I couldn't run the tests because cask couldn't install. They are simple and from my understanding of the other definitions they should be at least mostly okay. 馃槄