Added basic support for solidity language. #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrkrshnn
force-pushed
the
add-solidity-support
branch
from
a73807e
to
d6ab59d
Compare
jacktasia
reviewed
Jun 22, 2021
dumb-jump.el
Outdated
|
|
||
| (:type "event" :supports ("ag" "grep" "rg" "git-grep") :language "solidity" | ||
| :regex "event\\s*JJJ\\s*\\\(" | ||
| :tests ("event test();" "event test (uint indexed x)" "function test(uint x, address y)")) |
There was a problem hiding this comment.
Tests are failing on function test(uint x, address y), which makes sense as this regex is only looking for event
|
Thanks for opening this! Looks like a tiny test failure that needs to be fixed (commented above) |
Can jump into functions, modifiers, events and custom errors.
hrkrshnn
force-pushed
the
add-solidity-support
branch
from
d6ab59d
to
59b5eab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can jump into functions, modifiers, events and custom errors.