Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zsh support #48

Merged
merged 3 commits into from Jun 6, 2016
Merged

Add zsh support #48

merged 3 commits into from Jun 6, 2016

Conversation

abend
Copy link
Contributor

@abend abend commented Jun 6, 2016

Hi. Thanks for this great package!

I had trouble running the tests using zsh. It appears to be a difference in how bash and zsh handle single quotes inside single quoted strings. I think bash is a little more lenient.

This fix allows the tests to pass under zsh, bash, and sh. Csh and ksh still have problems, but since I don't use them, I haven't put any effort into them.

If you like, I can add a feature that runs the tests under different shells (if installed). I wanted to keep this patch small though.

Let me know if you'd like anything changed.

Thanks!

@coveralls
Copy link

coveralls commented Jun 6, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 282497a on abend:feature/zsh-support into 590773b on jacktasia:master.

@jacktasia
Copy link
Owner

Awesome, thanks for doing this!

@jacktasia jacktasia merged commit de29562 into jacktasia:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants