Sync config on initialization; adding tests #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedickey
added a commit
that referenced
this pull request
May 5, 2022
* Added initial version of analog bridge mixer * Adding autoconnector to support patching of hubserver<->zita * Removing all jack client interaction from deviceMixer * Fixing bugs around crossed-wires * Cleaning up deviceMixer * Support for dummy jack device * Add handling for dummy/non-alsa device * Channel detection working * Added multi channel connect * Update feature/autoconnector-integration (#60) * Switching build to produce arm binaries (#55) * Adding support for experimental queue size settings (#54) * Don't reset device if only Broadcast state changes on server (#56) * Adding expiresAt in heartbeat so server is aware of expiration time (#59) Co-authored-by: mikedickey <mike@mikedickey.com> * Bugfix/handling zita port race conditions (#62) * Enable zita <-> Jamulus port connections * Make device mixer a separate goroutine; added error handling around race conditions * Addressing PR review comments * Bugfixes around server settings changes * Fixing analog bridge sound device name setting * Adding unit tests, moving code around * Wiring up logic around EnableUSB flag * Adding Fender Micro test case (capture device only) * Find best channel number based on sample rate; more tests and code cl… (#65) * Find best channel number based on sample rate; more tests and code cleanup * Rename zita service name template * Support buffer size/period in zita * Change capture/playback volume to iterate through cards and detect co… (#66) * Change capture/playback volume to iterate through cards and detect controls * Use best-approximate sample rate for zita; update ALSA settings on device detection * Enabling default sample rate/channel for built-in sound; support for multi-digit card numbers (#67) * Reverting checks for b1/Headphones from built-in (#68) * Sync config on initialization; adding tests (#69) * Make first config sync apply to only analog bridge * Feature/monitor and mute controls (#71) * Adding new ALSA fields (#70) * Adding finer support for monitor volume and mute toggles * Adding monitor and mute controls * Set volumes to zero percent when muted (#72) * Set volumes to zero percent when muted * Only set "Analogue Playback Volume" once for hifiberry cards * Adding signal handler + context cancellation to subroutines; restore state on disconnect or enableUSB switch for analog bridge * Fixing lint/fmt warnings Co-authored-by: mikedickey <mike@mikedickey.com> Co-authored-by: nwang92 <nwang92@gmail.com> Co-authored-by: Nelson Wang <nwang92@users.noreply.github.com> Co-authored-by: mikedickey <mike@mikedickey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the problem with the hifiberry volumes on startup is mostly due to how go struct comparisons are performed. When an analog bridge is registered, it saves with
PlaybackVolume: 0, CaptureVolume: 0. When jacktrip-agent starts, it initializes an emptycurrentDeviceConfigAgentConfig withPlaybackVolume: 0, CaptureVolume: 0.This causes the
config.ALSAConfig != lastDeviceConfig.ALSAConfigcomparison to be false and never update volumes. I'm adding a first-config-check to force initialization here.