Plc auto #514
Merged
Plc auto #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tr parser handling auto in the CLI, for example, -q auto, -q auto15, translates to -500, -15 and does the right thing
ntonnaett
approved these changes
Mar 27, 2022
| int longTermCnt; | ||
| int plcUnderruns; | ||
| int lastPlcUnderruns; |
There was a problem hiding this comment.
It looks like a lot of these could be private.
I would also like to see that we use mCamelCase for members everywhere. But this can be done automatically with clang-tidy. So don't start to change this manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements auto mode for bufstrategy 3
CLI syntax as with bufstrategy 1 but meaning is different
the example session below uses auto15 which specifies start with 15ms for bufstrategy 3 tolerance setting
during the first 2 seconds of connection statistics are gathered and
then the 15ms gets modified up or down, servo'ed by longterm std dev and avg max
interpacket arrival
tested (fedora):
server: (at 64 FPP, stereo)
./jacktrip -S --bufstrategy 3 --udprt -p1 -q auto15 -I 1
client:
PIPEWIRE_LATENCY="64/48000" ./jacktrip -C --bufstrategy 3 --udprt -I 1 -n 1 -q auto15