New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create separate arguments for input and output devices #858
Conversation
Fix for Issue #495. Use separate arguments for input and output devices.
Thanks for your PR! Looks straight forward. Is this tested with device name including a comma?
|
I tested with these devices: Looks like there was one format issue. I fixed it in my branch. Not sure what to do here. |
Fix format issue.
I'm happy with this. The naming of the flags is nice for when we get tab completion one day. Let's see what others think. @dyfer @psiborg112 @cchafe |
Looks good to me. Doesn't prevent people from doing things the current way if they're already in the habit of that (or have existing scripts they're using) while fixing the issue. |
Do you have an idea for this? Counting the commas? May be something for another PR. |
Oh no, I just meant that it doesn't stop the current option from working the way people are used to while adding the necessary options to fix the comma issue. I don't think there's a more elegant solution than that. |
Yeah, I agree. But the case for more than one comma for --audiodevice is broken. So we could warn if it's more than 1 and tell the user to use the new flags. |
Yes, a warning would probably be good in that circumstance - but definitely for a future PR. |
Fix for Issue #495. Use separate arguments for input and output devices.