New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OP: enable Resize/Prelu/Sigmoid, modified Reshape #25
Conversation
Hi @erizmr thanks for your contribution! It seems you forget to include the TFLite model file of |
For adding TFLite model files, you may need to use |
Thanks! Have uploaded the missing models. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erizmr thank you for your great contribution! I have some minor comments, and I will read the Resize
part tomorrow.
Btw, would you mind helping to update the Operator Support Status to demonstrate the new ops in this PR?
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
+ Coverage 95.13% 95.31% +0.18%
==========================================
Files 26 27 +1
Lines 1458 1559 +101
==========================================
+ Hits 1387 1486 +99
- Misses 71 73 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erizmr Thanks for your active work on this :) I have quick look at the Resize
part and left several comments, but I need some time to check the interpolation in detail still.
The Codecov requires coverage don't drop > 1% (I am not sure if it's correctly configured though...), we may try to get that.
LINES=26; export COLUMNS LINES;
Hi @jackwish , thanks for your review! Please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erizmr LGTM in general, thanks for your contribution!
Hi @jackwish ,
The main contributions in this PR are listed below:
Resize
,Prelu
,Sigmoid
(seems that Sigmoid has been developed in another pull request, sorry for this redundant work..)Reshape
to adapt cases with one attributeThanks for your awesome code review in advance :)