Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve semantic of TransposeConv #26

Closed
5 tasks done
zhenhuaw-me opened this issue Nov 11, 2020 · 9 comments
Closed
5 tasks done

Improve semantic of TransposeConv #26

zhenhuaw-me opened this issue Nov 11, 2020 · 9 comments
Labels
help wanted Extra attention is needed Operator Operator

Comments

@zhenhuaw-me zhenhuaw-me added the Enhancement New feature or request label Nov 11, 2020
@zhenhuaw-me zhenhuaw-me added this to Proposed in v0.4 - Quantization Enhancement via automation Nov 11, 2020
@zhenhuaw-me zhenhuaw-me moved this from Proposed to To Do in v0.4 - Quantization Enhancement Nov 11, 2020
@zhenhuaw-me zhenhuaw-me moved this from To Do to In Progress in v0.4 - Quantization Enhancement Nov 13, 2020
@zhenhuaw-me zhenhuaw-me added the help wanted Extra attention is needed label Nov 20, 2020
@zhenhuaw-me
Copy link
Owner Author

TODO of TransposeConv (due to we do not fully understand the semantic gap) #21 (comment)

  1. Special output shape for VALID padding
  2. Different input/output shape for SAME padding

@zhenhuaw-me zhenhuaw-me changed the title Small TODO items: Next Improve semantic of TransposeConv Dec 15, 2020
@zhenhuaw-me
Copy link
Owner Author

changed the title to track the TransposeConv issue, will not track others anymore.

@zhenhuaw-me zhenhuaw-me moved this from In Progress to To Do in v0.4 - Quantization Enhancement Dec 15, 2020
@zhenhuaw-me zhenhuaw-me added Operator Operator and removed Enhancement New feature or request labels Dec 30, 2020
@zhenhuaw-me zhenhuaw-me moved this from To Do to Done in v0.4 - Quantization Enhancement Aug 30, 2021
@zhenhuaw-me
Copy link
Owner Author

all done

@ed-mr
Copy link

ed-mr commented Apr 11, 2022

Is there any follow-up on this issue? Since I am not happy about the current decision, that onnx is not supporting NHWC order for half its operators. For all the folks using Conv and TF/Keras it would be the strait thing to support NHWC as onnx attribute in storage_order in the first right in the first place

@zhenhuaw-me
Copy link
Owner Author

@ed-mr I am sorry but what's the contex are you refering to?

@ed-mr
Copy link

ed-mr commented Apr 11, 2022

just a sort summary. I just stumbled over this old already closed issue. Which I would like to have questions about. Since to my understanding, it would be much better to improve onnx and provide the "storage_order" attribute to conv and gain abstraction. That way, tf2onnx can easily use its default data_format = "columns_last".
see details on the issue I raised ealier; also onnx/tensorflow #1910 and onnx #4099
I would be happy to see this, since it resolves issues on the backend sides. (I working with tvm)

@zhenhuaw-me
Copy link
Owner Author

Yeah, I absolutely agree that ONNX needs to improve for these layout issues. I like the idea of storage_order and I think I have seen somewhere there is related discussions about supporting different layouts. But that would require the ONNX community to drive which is out of the scope of this project :)

I doubt that won't happen soon since the ONNX community would prioritize other things - it's not a blocking issue and we can always workaround it...

@ed-mr
Copy link

ed-mr commented Apr 12, 2022

Besides the fact, that I would be in favour or the storage_order, I figure from the discussion I raised in the ONNX community #4099, the onnx-people might pick up such issue as local functions as described in #3877. Reason sounds ok, they claim that ONNX operator basis becomes to big, since there are many operators to be adopted. I as a small user, and not a contributor I am certainly not able to convince anybody on that end. It might need some involvement from this project. Only issue I see is, to get the named operators NHWCConv on the list mentioned.

@zhenhuaw-me
Copy link
Owner Author

@ed-mr Thanks, let me commont on the thread you initialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Operator Operator
Projects
No open projects
Development

No branches or pull requests

2 participants