Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tapable.plugin is deprecated. #5

Closed
X-Tender opened this issue Apr 12, 2018 · 0 comments
Closed

Tapable.plugin is deprecated. #5

X-Tender opened this issue Apr 12, 2018 · 0 comments

Comments

@X-Tender
Copy link

Got this error with webpack 4.

(node:26967) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead

I would create a pull request but I really don't know how to fix this.
welwood08 added a commit to welwood08/del-webpack-plugin that referenced this issue Apr 15, 2018
@welwood08
Webpack v4 compatibility
e24289e 
In my limited testing as a new webpack user, this plugin already works fine with webpack v4 so all that's needed is to squash the deprecation warning. I expect this change to be fully backwards compatible with older webpack versions.

I'm making this change using the Github web interface so please excuse any silly mistakes or lack of testing!

Fixes jackypan1989#5
@welwood08 welwood08 mentioned this issue Apr 15, 2018
Merged
@jackypan1989 jackypan1989 mentioned this issue May 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@X-Tender