Highly customizable Favicon(s) feature #146
Conversation
…ict and string input format
content/notes/config.md
Outdated
| @@ -23,6 +23,40 @@ links: # Links to show in footer | |||
| link: https://github.com/jackyzha0 | |||
| ``` | |||
|
|
|||
| ### HTML Favicons | |||
|
|
|||
| If you would like to customize the favicons of your website, you can add them to the `data/config.yaml` file. The default without any set `favicon` key is: | |||
There was a problem hiding this comment.
a short explainer on favicons (even just "the icon you see in the tab bar" or something) would be really nice
|
|
||
| ```yaml | ||
| favicon: | | ||
| <link rel="shortcut icon" href="icon.png" type="image/png"> |
There was a problem hiding this comment.
this should also have multiple favicons to match the text above
There was a problem hiding this comment.
Very good point, fixed 🎯
layouts/partials/head.html
Outdated
| {{ $favicon | safeHTML }} | ||
| {{ else }} | ||
| {{ range $favicon }} | ||
| <link rel="{{.rel}}" {{if .type}}type="{{.type}}"{{end}} {{if .sizes}}sizes="{{.sizes}}"{{end}} href="{{$.Site.BaseURL}}{{.href}}" /> |
There was a problem hiding this comment.
does the href here include the / ? this seems to do {{$.Site.BaseURL}}icon.png for the default
There was a problem hiding this comment.
{{$.Site.BaseURL}} is defined as https://quartz.jzhao.xyz/ by default in the config.toml, so this works in this case: https://quartz.jzhao.xyz/icon.png, but you're right, if the baseURL is defined without the trailing /, this would cause an issue. I added a / between the two template arguments, because afaik, ...///... shouldn't be an issue.
…lanation throughout
Initially assumed that `href` definitions should have `/...` as their pattern, and `baseURL` would always end with `/`, however the omission of `/` as the prefix of the former and suffix of the latter simultaneously, would result in broken favicon paths. Final comment: `..///...` is not breaking, which is worst case scenario with this fix.
Hi, firstly I'd like to say thank you for such an incredible tool. I've made some interesting additions which may be very useful to more than just me. This PR includes my changes for highly customizable Favicons for your personal quartz website.
Without adding the
faviconkey to thedata/config.yamlfile for quartz, everything will generate as it did before.For users who want to customize their Favicons themselves, perhaps as generated by Favicon generator websites, they can do so by defining a value to the
faviconkey.The default in quartz:
Is equivalent to defining the
faviconkey in thedata/config.yamlas:or
If you find this useful and the modifications aren't as desired, please provide feedback and I'll make adjustments for the future :)