Add GitHub "edit" button #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
reviewed
Jul 4, 2022
layouts/_default/single.html
Outdated
| @@ -15,7 +15,8 @@ <h1 id="page-title"><a href="{{ .Site.BaseURL }}">{{ .Site.Data.config.page_titl | |||
| <article> | |||
| {{if .Title}}<h1>{{ .Title }}</h1>{{end}} | |||
| <p class="meta"> | |||
| Last updated {{if ne .Date .Lastmod}}{{ .Lastmod.Format "January 2, 2006" }}{{else}}Unknown{{end}} | |||
| Last updated {{if ne .Date .Lastmod}}{{ .Lastmod.Format "January 2, 2006" }}{{else}}Unknown{{end}}. | |||
| {{ partial "github.html" . }} | |||
There was a problem hiding this comment.
can we change this to spaces to keep it consistent?
layouts/partials/github.html
Outdated
| @@ -0,0 +1,3 @@ | |||
| {{if $.Site.Data.config.onGitHub}} | |||
| <a href="{{$.Site.Data.config.GHlink}}/{{ .Path}}" rel="noopener">Edit</a> | |||
There was a problem hiding this comment.
Suggested change
| <a href="{{$.Site.Data.config.GHlink}}/{{ .Path}}" rel="noopener">Edit</a> | |
| <a href="{{$.Site.Data.config.GHlink}}/{{ .Path}}" rel="noopener">Edit Source</a> |
|
applied 👌 |
jackyzha0
approved these changes
Jul 5, 2022
j0nesma
pushed a commit
to j0nesma/quartz
that referenced
this pull request
Sep 22, 2023
tomoyanonymous
pushed a commit
to tomoyanonymous/quartz-research-note
that referenced
this pull request
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a GitHub edit button beside the Date update text.
Demo: https://rphla.github.io/garden/+Home/