make footer contact links responsive #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyzha0
reviewed
Apr 2, 2022
There was a problem hiding this comment.
Hi @meleu, thanks for this contribution! I would prefer to avoid special HTML entities wherever possible :) Could you wrap the <a> tags in the footer with a <ul> and then styling the list elements to all be inline-blocks? This should solve the line break problem in a more semantically meaningful manner
jackyzha0
approved these changes
Apr 2, 2022
|
Thanks for the speedy update :)) |
|
wow! are you a robot? 🤖 thanks again for creating quartz! ❤️ |
meleu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we put a bunch of
linksinsidedata/config.yamlwe can see a horizontal scrolling like this:This happens because in
layouts/partials/contact.htmlthe links are generated with no spaces between them.I managed to solve this adding a
​between each link. Here's how it looks now: