[#256] Add schemata-ts Newtypes #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob-alford
force-pushed
the
ja/256/newtypes
branch
from
a51b56e
to
9c5759f
Compare
Pull Request Test Coverage Report for Build 4169205174
💛 - Coveralls |
jacob-alford
force-pushed
the
ja/256/newtypes
branch
from
9c5759f
to
f416478
Compare
skeate
reviewed
Feb 13, 2023
scripts/generate-schemables.ts
Outdated
| export const instanceComment: ( | ||
| module: SchemableTypeclasses[0], | ||
| version: SchemableTypeclasses[3], | ||
| ) => ts.JSDoc = (module, verision) => |
Comment on lines
+194
to
+196
| `* ${ | ||
| typeclassName === 'Type' ? '@deprecated\n' : '' | ||
| }@since ${version}\n\n@category Model`, |
There was a problem hiding this comment.
wouldn't this produce a comment like
/**
* @deprecated
@since 1.4.0?
There was a problem hiding this comment.
Yeah, it gets fixed by prettier. I'm not sure if there's a way around that 🤔
jacob-alford
commented
Feb 13, 2023
src/brand.ts
Outdated
| * @since 1.4.0 | ||
| * @category Model | ||
| */ | ||
| export const fromRefinement = |
There was a problem hiding this comment.
Need to remove this, it doesn't make much sense to have
jacob-alford
force-pushed
the
ja/256/newtypes
branch
2 times, most recently
from
41fe693
to
b7a524d
Compare
jacob-alford
force-pushed
the
ja/256/newtypes
branch
from
b7a524d
to
054290a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
brandmodule: brand reexport, and schemata-ts Branding (backwards compatible)newtypemodule: schemata-ts specific newtypes (backwards compatible)isomodule: schemata-ts isomorphisms (compatible with monocle-ts experimental)Closes #256