Fix .d.ts errors #262
Merged
Fix .d.ts errors #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skeate
reviewed
May 5, 2023
Comment on lines
370
to
+371
| [K in keyof Props]: Props[K] extends Prop<infer Flag, any, infer Val, infer Remap> | ||
| ? Remap extends KeyNotMapped | ||
| ? Prop<Flag, S, Val, ApplyKeyRemap<R, K & string>> | ||
| : Prop<Flag, S, Val, ApplyKeyRemap<R, Remap & string>> | ||
| ? Val extends HKT2<S, any, any> |
There was a problem hiding this comment.
I wonder if Props[K] extends Prop<infer Flag, any, infer Val extends HKT2<S, any, any>, infer Remap> would work?
There was a problem hiding this comment.
I tried that, but Typescript generated that inner extends constraint with S_1 for some reason and was still erroring (because it couldn't find the variable S_1 🙃)
Pull Request Test Coverage Report for Build 4896156632
💛 - Coveralls |
skeate
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.