Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental meson.build file #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danyspin97
Copy link

No description provided.

meson.build Outdated
project('dstep', 'd', version: '1.0.1')

if get_option('buildtype') == 'release'
add_project_arguments('-O3', language: 'd')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. A project should never make this kind of decisions if not required.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been removed.

Copy link

@FFY00 FFY00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Perhaps there could be a better way to do the clang stuff but I don't have time to investigate.

@danyspin97
Copy link
Author

The current method uses llvm-config, which can also be configured when cross compiling according to the system.

@jacob-carlborg
Copy link
Owner

I don't think I want to have an additional build system. What's the reason for adding another one?

@FFY00
Copy link

FFY00 commented Dec 8, 2019

Dub is notoriously bad, especially when it comes to software distribution. Having a build system that actually supports pkgconf properly is very important IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants