Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input/Output dir options #248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Input/Output dir options #248

wants to merge 3 commits into from

Conversation

denizzzka
Copy link

Fix #243

jacob-carlborg
jacob-carlborg requested changes Jan 16, 2020
View reviewed changes
Copy link
Owner

@jacob-carlborg jacob-carlborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include tests and a changelog entry.

dstep/Configuration.d
string outputPath;

/// in case there are many input files or dir output option provided
bool isOutputToDir;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the intention that both -O and -o are specified since this is a bool?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@denizzzka
Copy link
Author

Please include tests

I could not do this so that there were a minimum number of changes.

@denizzzka
Copy link
Author

I run it by this way:

dstep -I -O -o ./dst_dir/ ./src_dir/

@jacob-carlborg
Copy link
Owner

I could not do this so that there were a minimum number of changes.

I’m not sure I follow. You can have a look here at how to to implement a test:

https://github.com/jacob-carlborg/dstep/blob/master/tests/functional/Tests.d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-carlborg jacob-carlborg jacob-carlborg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please add dedicated output directory argument
2 participants
@denizzzka @jacob-carlborg