Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more statement not reachable warnings #51

Merged
merged 2 commits into from Jul 14, 2018

Conversation

Timoses
Copy link
Contributor

@Timoses Timoses commented Jul 14, 2018

Removed buildRequirements "silenceWarnings" in dub.sdl to identify more warnings.

Only 2 else (static) statements added.

@jacob-carlborg
Copy link
Owner

Does this fix all warnings? In that case the change can include removing buildRequirements "silenceWarnings".

@Timoses
Copy link
Contributor Author

Timoses commented Jul 14, 2018

I suppose it does, as I ran dub test with buildRequirements "silenceWarnings" removed (checked compiler arguments with dub test -v and it compiled with -w).
I've added another commit with the change.

@jacob-carlborg jacob-carlborg merged commit e14d35d into jacob-carlborg:master Jul 14, 2018
@jacob-carlborg
Copy link
Owner

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants