Add lightweight tags variable funcionality, resolves #14 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to be described
jacob-meacham
requested changes
Sep 19, 2018
| @@ -18,6 +18,10 @@ functions: | |||
| name: ${self:provider.stage}-${self:service}-process-event-batch | |||
| description: ${git:branch} - ${git:describe} - ${git:sha1} | |||
|
|
|||
| processEventBatch2: | |||
There was a problem hiding this comment.
Since describeLight isn't a built-in for git, can you add some more documentation to the README as to what it does?
There was a problem hiding this comment.
Commit #44a193e has added documentation as requested.
Added explanation of `describeLight` and its difference to `describe`
jacob-meacham
approved these changes
Sep 24, 2018
|
@domroutley thanks so much for the improvement! |
|
@domroutley Released as 3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds the ability for users to use a variable in serverless
${git:describeLight}that will resolve to
git describe --always --tags. This is desirable because it will allow the display of lightweight tags (such as those generated when using GitHub releases). resolves #14Checklist