Support custom controller UI/API port for HEALTHCHECK #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HEALTHCHECK command hard-codes the default controller UI/API port. This fails (shows the container status as unhealthy) if the user has specified a custom port for it in the system properties file. Make this work correctly in such cases by parsing the port from the file if it is present and uncommented. In order to avoid a stupidly complicated one-liner move the healthcheck command into a separate shell script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HEALTHCHECK command hard-codes the default controller UI/API port.
This fails (shows the container status as unhealthy) if the user has
specified a custom port for it in the system properties file.
Make this work correctly in such cases by parsing the port from the file
if it is present and uncommented. In order to avoid a stupidly
complicated one-liner move the healthcheck command into a separate shell
script.