Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add debugging logs and refactor json calls #11 #12

Merged
merged 1 commit into from
Feb 20, 2023
Merged

add debugging logs and refactor json calls #11 #12

merged 1 commit into from
Feb 20, 2023

Conversation

jacobdonenfeld
Copy link
Owner

@jacobdonenfeld jacobdonenfeld commented Feb 20, 2023 •
edited

Closes #11

@jacobdonenfeld jacobdonenfeld self-assigned this Feb 20, 2023
@jacobdonenfeld jacobdonenfeld added the enhancement New feature or request label Feb 20, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 20, 2023
View reviewed changes
custom_components/aerogarden/__init__.py
_LOGGER.exception(
"error: Could not marshall post request to json.\n post:\n%s\n\nexception:\n%s",
str(r),
post_data,

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text. This expression logs [sensitive data (password)](2) as clear text. This expression logs [sensitive data (password)](3) as clear text.
@jacobdonenfeld
add debugging logs and refactor json calls
d319a92 
Signed-off-by: jacobdonenfeld <jedonenfeld@gmail.com>
@jacobdonenfeld jacobdonenfeld merged commit 378d447 into master Feb 20, 2023
@jacobdonenfeld jacobdonenfeld deleted the add-debugging branch February 20, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jacobdonenfeld jacobdonenfeld

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Add debug logs and refactor requests
1 participant
@jacobdonenfeld