Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix curl, add tests, add CI actions #14

Merged
merged 1 commit into from
Feb 26, 2023
Merged

fix curl, add tests, add CI actions #14

merged 1 commit into from
Feb 26, 2023

Conversation

jacobdonenfeld
Copy link
Owner

No description provided.

@jacobdonenfeld jacobdonenfeld force-pushed the fix-logging branch 11 times, most recently from 70647cc to e2da5f5 Compare February 26, 2023 07:06
Signed-off-by: jacobdonenfeld <jedonenfeld@gmail.com>
Comment on lines +102 to +103
"Login URL: %s, post data: %s, headers: %s "
% (url, cleanPassword(str(post_data), self._password), self._headers)

Check failure

Code scanning / CodeQL

Clear-text logging of sensitive information

This expression logs [sensitive data (password)](1) as clear text. This expression logs [sensitive data (password)](2) as clear text. This expression logs [sensitive data (password)](3) as clear text. This expression logs [sensitive data (password)](4) as clear text.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Password is filtered out

@jacobdonenfeld jacobdonenfeld merged commit 125fcab into master Feb 26, 2023
@jacobdonenfeld jacobdonenfeld deleted the fix-logging branch February 26, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant