Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #131 and fix #76 added new message filtering #138

Merged
merged 1 commit into from
Apr 11, 2017
Merged

Conversation

Philippe229
Copy link
Collaborator

Description

Added filtering when a user sends a new message in a study group chat. The new message will only display for other users if they have the same study group chat open.

Breakdown

  • Added a new argument in the 'UpdateMessages' socket event to pass the study group guid back to the front end.
  • Added a condition to filter the need to update the currently opened chat with a new message

Testing

  • Tested locally with two different users (on different browsers) sending messages in groups they share

Copy link
Collaborator

@simon-bourque simon-bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Front end is pretty much what I would have done

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.0% when pulling 70abdba on chat_filtering into f6c0173 on master.

Copy link
Contributor

@pbgnz pbgnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MartinSpasov MartinSpasov self-requested a review April 11, 2017 23:35
Copy link
Collaborator

@MartinSpasov MartinSpasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well!

@Philippe229 Philippe229 merged commit f8086f5 into master Apr 11, 2017
@Philippe229 Philippe229 deleted the chat_filtering branch April 12, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants